| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_upgrade should truncate/remove its logs before running |
| Date: | 2021-12-16 01:39:05 |
| Message-ID: | YbqYuQkoXm8IytZ0@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 15, 2021 at 04:13:10PM -0600, Justin Pryzby wrote:
> On Wed, Dec 15, 2021 at 05:04:54PM -0500, Andrew Dunstan wrote:
>> The directory name needs to be predictable somehow, or maybe optionally
>> set as a parameter. Having just a timestamped directory name would make
>> life annoying for a poor buildfarm maintainer. Also, please don't change
>> anything before I have a chance to adjust the buildfarm code to what is
>> going to be done.
>
> Feel free to suggest the desirable behavior.
> It could write to pg_upgrade.log/* and refuse to run if the dir already exists.
Andrew's point looks rather sensible to me. So, this stuff should
have a predictable name (pg_upgrade.log, pg_upgrade_log or upgrade_log
would be fine). But I would also add an option to be able to define a
custom log path. The latter would be useful for the regression tests
so as everything gets could get redirected to a path already filtered
out.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hsu, John | 2021-12-16 02:15:42 | Re: Synchronizing slots from primary to standby |
| Previous Message | Jacob Champion | 2021-12-16 01:13:57 | [PATCH] Accept IP addresses in server certificate SANs |