| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: GUC flags |
| Date: | 2021-12-08 06:27:19 |
| Message-ID: | YbBQR8BKcbQ8dTR6@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 06, 2021 at 07:36:55AM -0600, Justin Pryzby wrote:
> The script checks that guc.c and sample config are consistent.
>
> I think your undertanding of INTENTIONALLY_NOT_INCLUDED is not right.
> That's a list of stuff it "avoids reporting" as an suspected error, not an
> additional list of stuff to checks. INTENTIONALLY_NOT_INCLUDED is a list of
> stuff like NOT_IN_SAMPLE, which is better done by parsing /NOT_IN_SAMPLE/.
Indeed. I got that wrong, thanks for clarifying.
> I saw that Tom updated it within the last 12 months, which I took to mean that
> it was still being maintained. But I'm okay with removing it.
Yes, I saw that as of bf8a662. With 42 incorrect reports, I still see
more evidence with removing it. Before doing anything, let's wait for
and gather some opinions. I am adding Bruce (as the original author)
and Tom in CC as they are the ones who have updated this script the
most in the last ~15 years.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-12-08 06:28:51 | Re: row filtering for logical replication |
| Previous Message | Masahiko Sawada | 2021-12-08 06:17:52 | Re: Skipping logical replication transactions on subscriber side |