Re: pgsql: psql: initialize comment-begin setting to a useful value by defa

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: psql: initialize comment-begin setting to a useful value by defa
Date: 2021-12-02 06:53:17
Message-ID: YahtXUVtBeh+P7oL@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Tom,

On Wed, Dec 01, 2021 at 05:24:58PM +0000, Tom Lane wrote:
> psql: initialize comment-begin setting to a useful value by default.
>
> Readline's meta-# command is supposed to insert a comment marker
> at the start of the current line. However, the default marker is
> "#" which is entirely unhelpful for SQL. Set it to "-- " instead.
> (This setting can still be overridden in one's ~/.inputrc file,
> so this change won't affect people who have already taken steps
> to make the command useful.)

prairiedog is unhappy after this commit due to the use of
rl_variable_bind():
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prairiedog&dt=2021-12-02%2005%3A29%3A32

/usr/bin/ld: Undefined symbols:
_rl_variable_bind
collect2: ld returned 1 exit status

Thanks,
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-12-02 15:55:44 pgsql: pg_dump: Add missing relkind case
Previous Message Michael Paquier 2021-12-02 04:54:21 pgsql: pg_waldump: Emit stats summary when interrupted by SIGINT