Re: pg_waldump stucks with options --follow or -f and --stats or -z

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_waldump stucks with options --follow or -f and --stats or -z
Date: 2021-11-28 04:19:55
Message-ID: YaMDa2IHilAGGf0n@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 26, 2021 at 03:47:30PM +0530, Bharath Rupireddy wrote:
> On Fri, Nov 26, 2021 at 11:50 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>> + When <option>--follow</option> is used with <option>--stats</option> and
>> + the <application>pg_waldump</application> is terminated or interrupted
>> + with signal <systemitem>SIGINT</systemitem> or <systemitem>SIGTERM</systemitem>
>> + or <systemitem>SIGQUIT</systemitem>, the summary statistics computed
>> + as of the termination will be displayed.
>> This description is not completely correct, as the set of stats would
>> show up only by using --stats, in non-quiet mode. Rather than
>> describing this behavior at the end of the docs, I think that it would
>> be better to add a new paragraph in the description of --stats.
>
> Done.

v4 is just moving this paragraph in its correct subsection. My
wording may have been confusing here, sorry about that. What I meant
is that there is no need to mention --follow at all, as an
interruption done before reaching the end LSN or the end of WAL would
still print out the stats accumulated up to the interrupted point.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-11-28 04:32:53 Re: Deduplicate code updating ControleFile's DBState.
Previous Message Bharath Rupireddy 2021-11-28 02:35:52 Re: Unnecessary delay in streaming replication due to replay lag