Re: pgsql: Add table to regression tests for binary-compatibility checks in

On Thu, Nov 18, 2021 at 01:38:30AM +0000, Michael Paquier wrote:
> Add table to regression tests for binary-compatibility checks in pg_upgrade
>
> This commit adds to the main regression test suite a table with all
> the in-core data types (some exceptions apply). This table is not
> dropped, so as pg_upgrade would be able to check the binary
> compatibility of the types tracked in the table. If a new type is added
> in core, this part of the tests would need a refresh but the tests are
> designed to fail if that were to happen.

prion has been failing in a fancy way:
arraymultirange(arrayrange(ARRAY[1,2], ARRAY[2,1]));
+ERROR: unrecognized key word: "ec2"
+HINT: ACL key word must be "group" or "user".

That's an environment-related issue, as the user name of this animal
uses an hyphen "ec2-user", and this is bumping on the generation of
the aclitem. This is missing some quote_ident()'s, visibly.
--
Michael