Re: BUG #17288: PSQL bug with COPY command (Windows)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #17288: PSQL bug with COPY command (Windows)
Date: 2021-11-25 03:23:41
Message-ID: YZ8BvVysOLJcTP16@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Wed, Nov 24, 2021 at 10:44:09AM +0300, Dmitry Koval wrote:
> Unfortunately, you are.
> All my COPY-tests work well with files.
> I see a problem in the terminal only ...

While checking all the callers of fstat() in the core code, I have
discovered that this broke a second case when stdout is not
redirected: pg_recvlogical -f -. In this case, the code would just
bump on EINVAL repeatedly instead of crashing, but equally broken it
was. There is a TAP test for this case in src/bin/pg_basebackup/, but
it would not trigger the problem per the redirection already done
there.

Anyway, I have run more tests, tweaked slightly the comment, and
applied it down to 14. Thanks to both of you!
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message PG Bug reporting form 2021-11-25 17:53:34 BUG #17298: Error in func pg_get_serial_sequence()
Previous Message Ian R. Campbell 2021-11-24 22:13:17 range_agg() missing support for multirange inputs