| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | a(dot)kozhemyakin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17280: global-buffer-overflow on select from pg_stat_slru |
| Date: | 2021-11-11 02:52:27 |
| Message-ID: | YYyFawH87Sv3VZGi@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Nov 11, 2021 at 10:39:23AM +0900, Kyotaro Horiguchi wrote:
> The loop is designed not to directly rely on SRLU_NUM_ELEMENTS so if
> we honor that design, we would take the first or the third way. The
> first way is smallest but I prefer the third way as it is
> straightforward as such kind of loops. The attached is that for the
> master.
>
> The code was introduced at 13 and the attached applies to the versions
> back to 13.
Or it would be easier for the reader to assign stat after checking for
the result of pgstat_slru_name(), no? I am not much a fan of this
code style that uses a counter, FWIW, but at the same time
SLRU_NUM_ELEMENTS is local to pgstat.c, so..
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-11-11 03:08:21 | Re: BUG #17255: Server crashes in index_delete_sort_cmp() due to race condition with vacuum |
| Previous Message | Peter Geoghegan | 2021-11-11 02:40:13 | Re: BUG #17255: Server crashes in index_delete_sort_cmp() due to race condition with vacuum |