Re: [PATCH] Make ENOSPC not fatal in semaphore creation

From: Mikhail <mp39590(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Make ENOSPC not fatal in semaphore creation
Date: 2021-10-25 15:37:47
Message-ID: YXbPS7RnZMoXnBBE@edge.lab.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Oct 17, 2021 at 10:29:24AM -0400, Tom Lane wrote:
> Also, you haven't explained why the existing (and much safer) recycling
> logic in IpcSemaphoreCreate doesn't solve your problem.

I think I'll drop the diffs, you're right that current proven logic need
not to be changed for such rare corner case, which DBA can fix.

I've added references to ipcs(1) and ipcrm(1) in OpenBSD's semget(2) man
page, so newcomer won't need to spend hours digging in sysv semas
management, if one would encounter the same situation as I did.

Thanks for reviews.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-10-25 15:38:51 Re: pg_dump versus ancient server versions
Previous Message Tomas Vondra 2021-10-25 15:33:36 Re: Feature request for adoptive indexes