From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Allow pg_signal_backend members to use pg_log_backend_memory_stats(). |
Date: | 2021-10-23 23:41:52 |
Message-ID: | YXSdwCaTSUuvt73I@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Oct 23, 2021 at 08:42:29PM +0000, Bossart, Nathan wrote:
> Otherwise, presumably we will need to update func.sgml and the comment
> above pg_log_backend_memory_contexts() in mcxtfuncs.c.
Yes, the documentation of any SQL function whose hardcoded superuser()
check is removed needs a refresh to outline that its execution can be
GRANT-ed post-initialization, and it should also document which system
roles are able to use it. See for instance pg_database_size(), that
mentions roles need to be a member of pg_read_all_stats.
> This is unrelated to this patch, but should we also consider opening
> up pg_reload_conf() and pg_rotate_logfile() to members of
> pg_signal_backend? Those are the other "server signaling functions" I
> see in the docs.
Yes, there is that as well.
+CREATE ROLE testrole1 IN ROLE pg_signal_backend;
+CREATE ROLE testrole2;
Any role created in the regression test needs to be prefixed with
"regress_", or builds with -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS
will complain (I just add that by default to not fall into this trap
again).
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2021-10-24 01:40:12 | pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR |
Previous Message | Michael Paquier | 2021-10-23 23:33:12 | Re: Refactoring: join MakeSingleTupleTableSlot() and MakeTupleTableSlot() |