| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Chris Bandy <bandy(dot)chris(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Lost logs with csvlog redirected to stderr under WIN32 service |
| Date: | 2021-10-08 02:57:27 |
| Message-ID: | YV+zlwBJxIGYhJpA@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 07, 2021 at 01:26:46PM +0900, Michael Paquier wrote:
> On Wed, Oct 06, 2021 at 09:33:24PM -0500, Chris Bandy wrote:
>>> + /* Write to CSV log, if enabled */
>>> + if ((Log_destination & LOG_DESTINATION_CSVLOG) != 0)
>>
>> This was originally "if (Log_destination & LOG_DESTINATION_CSVLOG)" and
>> other conditions nearby still lack the "!= 0". Whatever the preferred
>> style, the lines touched by this patch should probably do this consistently.
>
> Yeah. It looks like using a boolean expression here is easier for my
> brain.
I have played with this patch more this morning, adjusted this part,
and applied it as of 8b76f89.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2021-10-08 03:05:21 | Re: storing an explicit nonce |
| Previous Message | Noah Misch | 2021-10-08 02:56:59 | Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. |