Re: pgsql: Support "postgres -C" with runtime-computed GUCs

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Date: 2021-09-21 03:47:24
Message-ID: YUlVzPkVgEPjtmIB@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote:
> So the problem is that -C data_checksums requires permissions to be dropped,
> but the way it's invoked here that's not guaranteed... And I don't think we
> should remove that requirement, given that we're actually doing stuff to the
> lock file...

Hmm. One way I can think of to keep the test would be something like
that to avoid problems with pg_ctl redirecting the server's stderr to
stdout (hence the tweak for log_min_messages):
pg_ctl start -s -o '-C data_checksums -c log_min_messages=fatal'

This would print the parameter, while getting to stderr mostly a
"could not start server". Would that work for you?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2021-09-21 04:32:09 Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Previous Message Andres Freund 2021-09-21 03:20:40 Re: pgsql: Support "postgres -C" with runtime-computed GUCs