| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Magnus Hagander <magnus(at)hagander(dot)net>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-09-09 01:09:52 |
| Message-ID: | YTle4DpJXpYZ7iI1@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On Wed, Sep 08, 2021 at 04:10:41PM +0900, Fujii Masao wrote:
> + {"shared_memory_size", PGC_INTERNAL, RESOURCES_MEM,
>
> When reading the applied code, I found the category of shared_memory_size
> is RESOURCES_MEM. Why? This seems right because the parameter is related
> to memory resource. But since its context is PGC_INTERNAL, PRESET_OPTIONS
> is more proper as the category? BTW, the category of any other
> PGC_INTERNAL parameters seems to be PRESET_OPTIONS.
Yes, that's an oversight from me. I was looking at that yesterday,
noticed some exceptions in the GUC list with things not allowed in
files and just concluded that RESOURCES_MEM should be fine, but the
docs tell a different story. Thanks, fixed.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-09-09 04:19:14 | Re: Estimating HugePages Requirements? |
| Previous Message | Geoffrey Hoffman | 2021-09-08 18:51:37 | Trouble with docker volume for backup/restore |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2021-09-09 01:28:38 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Previous Message | Tom Lane | 2021-09-09 00:13:48 | Re: Regression in PG14 LookupFuncName |