| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Tab completion for ALTER TABLE … ADD … |
| Date: | 2021-08-30 00:55:53 |
| Message-ID: | YSwsmd44F3tjFyLI@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 27, 2021 at 11:52:33AM +0100, Dagfinn Ilmari Mannsåker wrote:
> That was easy enough to add (just a bit of extra fiddling to handle
> COLUMN being optional), done in the attached v2 patch.
This part was a bit misleading, as it would recommend a list of types
when specifying just ADD CONSTRAINT for example, so I have removed
it. An extra thing that felt a bit overdoing is the addition of KEY
after PRIMARY/FOREIGN.
> Doing a list of arbitrarily many comma-separated names is more
> complicated, so that can be the subject for another patch.
No objections to that. I have applied what we have now, as that's
already an improvement.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2021-08-30 01:12:07 | Re: Separate out FileSet from SharedFileSet (was Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o) |
| Previous Message | Justin Pryzby | 2021-08-30 00:26:42 | Re: Write visibility map during CLUSTER/VACUUM FULL |