| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH]Remove obsolete macro CHECKFLOATVAL in btree_gist |
| Date: | 2021-08-18 01:04:04 |
| Message-ID: | YRxchDHrEEClniKm@paquier.xyz |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 17, 2021 at 11:08:59AM +0000, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
> On Friday, August 6, 2021 11:14 PM, tanghy(dot)fnst(at)fujitsu(dot)com <tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
>> Commit 6bf0bc842 replaced float.c's CHECKFLOATVAL() macro with static inline subroutines,
>> but the fix introduced a performance regression as Tom Lane pointed out and fixed at 607f8ce74.
>>
>> Found obsolete CHECKFLOATVAL usage in contrib/btree_gist, and tried to fix it according to 607f8ce74.
>
> Added above patch in commit fest:
> https://commitfest.postgresql.org/34/3287/
Yes, that does not seem wise on performance grounds. The case of
!zero_is_valid is never reached, so it seems like this code was just a
copy-paste from the float code in the backend. Your patch looks right
to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2021-08-18 01:16:50 | RE: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o |
| Previous Message | Michael Paquier | 2021-08-18 00:43:49 | Re: Two patches to speed up pg_rewind. |