Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows
Date: 2021-07-30 12:40:12
Message-ID: YQPzLHwTNf/dXkQo@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Fri, Jul 30, 2021 at 07:42:45AM -0400, Andrew Dunstan wrote:
> Well that unsticks the test, so now it fails in an ordinary way, so +1
> for doing that. I must say that --no-loop seems a little ill-designed.
> Effectively we have to choose between zero loops and infinite loops. 
> But that seems to be a matter of ancient (or at least medieval) history.

Okay, done. We could add an option that defines a number of failures,
though I have yet to see a use for that in the field.

> I will see if a more modern zlib helps matters.

Thanks!
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-07-30 12:45:04 Re: pgsql: postgres_fdw: Fix handling of pending asynchronous requests.
Previous Message Robert Haas 2021-07-30 12:38:17 pgsql: Remove unnecessary call to ReadCheckpointRecord().