Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows
Date: 2021-07-30 00:29:24
Message-ID: YQNH5NbE4JwVHa2s@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Jul 29, 2021 at 01:26:22PM -0400, Andrew Dunstan wrote:
> It gets stuck in a loop like this:
>
> ok 19 - one partial WAL segment was created
> 0/2001968
> # Running: pg_receivewal -D H:/prog/bf/root/HEAD/pgsql.build/src/bin/pg_basebackup/tmp_check/t_020_pg_receivewal_primary_data/archive_wal --verbose --endpos 0/3000028 --compress 1
> pg_receivewal: starting log streaming at 0/2000000 (timeline 1)
> pg_receivewal: error: could not write 131072 bytes to WAL file "000000010000000000000002": Permission denied
> pg_receivewal: error: could not close file "000000010000000000000002": Permission denied
> pg_receivewal: disconnected; waiting 5 seconds to try again

Hmm. This error is strange. Still, it is an oversight of ffc9ddae to
not use --no-loop here for the two new commands of pg_receivewal
--endpos. Please see the attached.
--
Michael

Attachment Content-Type Size
receivewal-tap-loop.patch text/x-diff 934 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-07-30 03:21:02 pgsql: Remove unused argument in apply_handle_commit_internal().
Previous Message Alvaro Herrera 2021-07-29 21:26:55 pgsql: Close yet another race condition in replication slot test code