| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: More time spending with "delete pending" |
| Date: | 2021-07-08 07:47:12 |
| Message-ID: | YOatgGjMgnEFsnGL@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jul 08, 2021 at 07:00:01AM +0300, Alexander Lakhin wrote:
> As Tom Lane noted above, the code added with bed90759f is dubious
> (_NtQueryInformationFile() can not be used to handle the "delete
> pending" state as CreateFile() returns INVALID_HANDLE_VALUE in this case.)
> Probably that change should be reverted. Should I do it along with the
> proposed fix?
Ah, I see. I have managed to miss your point. If
_NtQueryInformationFile() cannot be used, then we'd actually miss the
contents for standardInfo and the pending deletion. If you could send
everything you have, that would be helpful! I'd like to test that
stuff by myself, with all the contents discussed at disposal for a
proper evaluation.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-07-08 07:54:49 | Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers. |
| Previous Message | Michael Paquier | 2021-07-08 07:37:12 | Re: A few assorted typos in comments |