| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Subject: | Re: More time spending with "delete pending" |
| Date: | 2021-07-06 08:33:35 |
| Message-ID: | YOQVX1f9/2s1ct6W@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 14, 2021 at 06:00:00PM +0300, Alexander Lakhin wrote:
> I believe that the patch attached to [1] should fix this issue. The
> patch still applies to master and makes the demotest (attached to [2])
> pass. Also I've prepared a trivial patch that makes pgwin32_open() use
> the original stat() function (as in the proposed change for _pgstat64()).
Hmm. Knowing that _pgfstat64() has some special handling related to
files pending for deletion, do we really need that on HEAD?
> - struct stat st;
> + struct microsoft_native_stat st;
>
> - if (stat(fileName, &st) != 0)
> + if (microsoft_native_stat(fileName, &st) != 0)
> {
> pg_usleep(100000);
> loops++;
This change looks like a good idea for the WIN32 emulation of open(),
taken independently.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-07-06 08:47:34 | Re: ECPG doesn't compile CREATE AS EXECUTE properly. |
| Previous Message | Kyotaro Horiguchi | 2021-07-06 08:29:27 | Re: ECPG bug fix: DECALRE STATEMENT and DEALLOCATE, DESCRIBE |