Re: Remove repeated calls to PQserverVersion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove repeated calls to PQserverVersion
Date: 2021-07-13 10:36:55
Message-ID: YO1sxx0yIFd/f2jn@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jul 13, 2021 at 07:02:27PM +1000, Peter Smith wrote:
> I found a few functions making unnecessary repeated calls to
> PQserverVersion(conn); instead of just calling once and assigning to a
> local variable.

Does it really matter? PQserverVersion() does a simple lookup at the
internals of PGconn.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2021-07-13 10:54:54 Re: Enhanced error message to include hint messages for redundant options error
Previous Message Michael Paquier 2021-07-13 10:31:56 Re: [PATCH] Pull general SASL framework out of SCRAM