Re: Some incorrect logs in TAP tests of pgbench

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Some incorrect logs in TAP tests of pgbench
Date: 2021-06-26 03:50:24
Message-ID: YNakAEiBYJSY1Vn1@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 25, 2021 at 09:37:50AM -0400, Andrew Dunstan wrote:
> Either that or dereference them, by printing @$out and @$err instead of
> $out and $err or something similar.

Looking again, we don't really lose context if we remove that, so done
this way.

> But probably the name of the test is sufficient. (What were we thinking
> in allowing this in the first place?)

No idea. This got introduced in v5 of what got committed as of
ed8a7c6:
https://www.postgresql.org/message-id/alpine.DEB.2.20.1705091641150.29373@lancre
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2021-06-26 04:41:40 Re: Deadlock risk while inserting directly into partition?
Previous Message Michael Paquier 2021-06-26 00:47:02 Re: [PATCH] Pull general SASL framework out of SCRAM