| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench |
| Date: | 2021-06-25 03:08:29 |
| Message-ID: | YNVIrQEl8voobc3y@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, Jun 24, 2021 at 10:26:18PM -0400, Andrew Dunstan wrote:
> Since the file isn't read in using slurp_file, that $ won't match
> because the lines will end \r\n instead of \n.
I did not remember this one with Msys, thanks. I am not sure that
there is any need for an eval block here actually once you remove
open()? What do you think about something like the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-tap-fix.patch | text/x-diff | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-06-25 06:02:01 | pgsql: Remove redundant variable pageSize in gistinitpage |
| Previous Message | Amit Kapila | 2021-06-25 02:54:11 | pgsql: Doc: Fix minor formatting issue in logicaldecoding.sgml. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-06-25 03:17:41 | Re: Doc chapter for Hash Indexes |
| Previous Message | Michael Paquier | 2021-06-25 02:45:44 | Re: SSL/TLS instead of SSL in docs |