| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Centralizing protective copying of utility statements |
| Date: | 2021-06-18 00:57:10 |
| Message-ID: | YMvvZp96z7xffnok@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jun 17, 2021 at 02:08:34PM -0700, Andres Freund wrote:
> Unfortunately github is annoying to search through - it doesn't seem to
> have any logic to prevent duplicates across repositories :(. Which means
> there's dozens of copies of postgres code included...
I agree with the position of doing something now while in beta. I
have not looked at the tree, but I am rather sure that we had changes
in the hooks while in beta phase in the past.
>> which admittedly is more than none, but it's not a huge number
>> either. I have to think that fixing this bug reliably is a
>> more important consideration.
>
> Sure!
The DECLARE CURSOR case in ExplainOneUtility() does a copy of a Query.
Perhaps a comment should be added to explain why a copy is still
required?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-06-18 01:08:27 | Re: Avoid call MaintainOldSnapshotTimeMapping, if old_snapshot_threshold is disabled. |
| Previous Message | Michael Paquier | 2021-06-18 00:30:49 | Re: pgbench logging broken by time logic changes |