| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: be-secure-gssapi.c and auth.c with setenv() not compatible on Windows |
| Date: | 2021-05-31 00:14:36 |
| Message-ID: | YLQqbG75bfe0lmvG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 29, 2021 at 10:44:14AM -0400, Tom Lane wrote:
> What I had in mind was to *only* add pgwin32_setenv, not setenv.c.
> There's no evidence that any other modern platform lacks setenv.
> Moreover, there's no issue in these branches unless your platform
> lacks setenv yet has GSS support.
I have been finally able to poke at that, resulting in the attached.
You are right that adding only the fallback implementation for
setenv() seems to be enough. I cannot get my environment to complain,
and the code compiles.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-fallback-implementation-for-setenv.patch | text/x-diff | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-05-31 01:25:00 | Re: Multiple hosts in connection string failed to failover in non-hot standby mode |
| Previous Message | Tom Lane | 2021-05-30 23:17:11 | Re: postgres_fdw batching vs. (re)creating the tuple slots |