Re: Remove "FROM" in "DELETE FROM" when using tab-completion

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Remove "FROM" in "DELETE FROM" when using tab-completion
Date: 2021-05-11 05:53:14
Message-ID: YJobylbmbDSHRq2A@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 10, 2021 at 07:14:54PM +0530, Dilip Kumar wrote:
> LGTM.

No objections from me to what you are doing here.

else if (TailMatches("DELETE", "FROM", MatchAny))
COMPLETE_WITH("USING", "WHERE");
- /* XXX: implement tab completion for DELETE ... USING */

Why are you removing that? This sentence is still true, no?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2021-05-11 05:58:38 Re: Inaccurate error message when set fdw batch_size to 0
Previous Message Laurenz Albe 2021-05-11 05:50:41 Re: PG 14 release notes, first draft