| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Inaccurate error message when set fdw batch_size to 0 |
| Date: | 2021-05-11 05:44:10 |
| Message-ID: | YJoZqlo6x49TaJK6@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 10, 2021 at 10:09:40AM -0400, Tom Lane wrote:
> Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
>> if (value < 0) "requires a zero or positive integer value"
>> if (value <= 0) "requires a positive integer value"
>
> I was thinking of avoiding the passive voice and writing
>
> "foo must be greater than zero"
Sounds like a good idea to me.
>> I'm not sure whether we should consider changing these messages:
>> remainder for hash partition must be a non-negative integer
>> parallel vacuum degree must be a non-negative integer
>> repeat count size must be a non-negative integer
>> number of workers must be a non-negative integer
>> %s requires a non-negative numeric value
>> distance in phrase operator should be non-negative and less than %d
>
> I think for consistency it'd be good to change 'em all. I'm almost
> tempted to put this matter into our message style guide too.
+1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2021-05-11 05:50:41 | Re: PG 14 release notes, first draft |
| Previous Message | Amit Langote | 2021-05-11 05:11:20 | Re: update/delete and execution-time partition pruning |