From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Some doubious error messages and comments |
Date: | 2021-05-10 06:52:15 |
Message-ID: | YJjYH6MeZ4tnjfSs@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 28, 2021 at 08:11:47AM -0500, Justin Pryzby wrote:
> On Wed, Apr 28, 2021 at 05:36:33PM +0900, Kyotaro Horiguchi wrote:
>> 0001: I found some typos in a error message and a comment.
>>
>> multirangetypes.c: 1420
>> > errmsg("range_intersect_agg must be called with a multirange")));
>>
>> This "range_intersect_agg" looks like a typo of "multirange_..".
>>
>> operatorcmds.c:303
>> > * Look up a join estimator function ny name, and verify that it has the
>>
>> "ny" looks like a typo of "by".
>
> "ny name" shows up a 2nd time.
>
> I have another "comment typos" patch - maybe someone will want to push them
> together.
Thanks. Two of them were already fixed, two of them are correct but
went missing so I have applied a fix for these. The change in
multirange_intersect_agg_transfn() is incorrect as the error refers to
the SQL function range_intersect_agg().
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2021-05-10 06:53:37 | Re: [HACKERS] logical decoding of two-phase transactions |
Previous Message | Julien Rouhaud | 2021-05-10 06:51:28 | Re: PG 14 release notes, first draft |