| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: INCLUDING COMPRESSION |
| Date: | 2021-04-15 02:54:58 |
| Message-ID: | YHerAixOhfR1ryXa@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs pgsql-hackers |
On Wed, Apr 14, 2021 at 11:46:58PM +0900, Fujii Masao wrote:
> The syntax for like_option in CREATE TABLE docs seems to forget to mention
> INCLUDING COMPRESSION option. I think the following fix is necessary.
> Patch attached.
>
> -{ INCLUDING | EXCLUDING } { COMMENTS | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
> +{ INCLUDING | EXCLUDING } { COMMENTS | COMPRESSION | CONSTRAINTS | DEFAULTS | GENERATED | IDENTITY | INDEXES | STATISTICS | STORAGE | ALL }
Indeed. May I ask at the same time why gram.y (TableLikeOption) and
parsenodes.h (CREATE_TABLE_LIKE_COMPRESSION) don't classify this new
option in alphabetical order with the rest? Ordering them makes
easier a review of them.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2021-04-15 06:47:56 | Date/Time Functions and Operators |
| Previous Message | Michael Paquier | 2021-04-15 01:48:25 | Re: Typo in psql doc |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2021-04-15 03:29:48 | Re: logical replication empty transactions |
| Previous Message | Peter Geoghegan | 2021-04-15 02:53:29 | Re: New IndexAM API controlling index vacuum strategies |