| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Refactor all TAP test suites doing connection checks |
| Date: | 2021-04-05 23:12:31 |
| Message-ID: | YGuZX/Vvpx//Rtsg@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, Apr 05, 2021 at 06:57:47PM -0400, Tom Lane wrote:
> No, I bet it is with "now defines a SQL query". That means there's
> something to be stuffed down the pipe.
>
> I find I can reproduce this pretty reliably on slower machines
> here, if you want me to dig into it more carefully.
Now that I think about it, another thing that has changed in this code
is the fact that it calls PostgresNode::psql with a result array
rather than just the error result, still I don't see how this would
have an impact? If you are right, it would be easy to bypass this
error with a change in the connect routines to be able to pass down
undefined queries rather than filling in a default one. But that does
not feel like the root of it.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-04-05 23:12:49 | Re: pgsql: Refactor all TAP test suites doing connection checks |
| Previous Message | Tom Lane | 2021-04-05 22:57:47 | Re: pgsql: Refactor all TAP test suites doing connection checks |