| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Andrew Dunstan <andrew(at)dunslane(dot)net>, "wangsh(dot)fnst(at)fujitsu(dot)com" <wangsh(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: invalid data in file backup_label problem on windows |
| Date: | 2021-04-01 00:56:02 |
| Message-ID: | YGUaIiYW32aok3S2@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2021 at 09:33:25AM -0400, David Steele wrote:
> Agreed. New patch attached.
Thanks, David.
> diff --git a/doc/src/sgml/backup.sgml b/doc/src/sgml/backup.sgml
> index c5557d5444..8c9186d277 100644
> --- a/doc/src/sgml/backup.sgml
> +++ b/doc/src/sgml/backup.sgml
> @@ -913,7 +913,8 @@ SELECT * FROM pg_stop_backup(false, true);
> <filename>backup_label</filename> in the root directory of the backup. The
> third field should be written to a file named
> <filename>tablespace_map</filename> unless the field is empty. These files are
> - vital to the backup working, and must be written without modification.
> + vital to the backup working and must be written byte for byte without
> + modification, which may require opening the file in binary mode.
Okay, that sounds good to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-04-01 00:58:19 | Re: New IndexAM API controlling index vacuum strategies |
| Previous Message | Kyotaro Horiguchi | 2021-04-01 00:35:32 | Re: Issue with point_ops and NaN |