| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Ярослав Пашинский <yarik97(dot)6(at)gmail(dot)com>, Postgres bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #16927: Postgres can`t access WAL files |
| Date: | 2021-03-19 22:32:43 |
| Message-ID: | YFUmi3diUlqyoL44@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Mar 19, 2021 at 04:19:50PM +0100, Magnus Hagander wrote:
> On Fri, Mar 19, 2021 at 4:14 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Given the evidence that there's a problem, I agree with reverting
>> that. I'd suggest keeping the cosmetic rename of the function,
>> but we have to put back the Windows-doesn't-HAVE_WORKING_LINK logic.
>
> +1. I think the indications are definitely clear enough that this has
> to go back in.
No problem from me to keep the rename, and so this leads to the simple
patch attached, then. Any comments?
>> Grepping in the v12 branch, I find a second use of HAVE_WORKING_LINK
>> in contrib/pg_standby. But that seems to be in a non-WIN32 code path,
>> so I don't think putting that back is necessary.
>
> .. and apart front aht I *really* doubt that one has many users,
> especially on Windows :)
Yeah, agreed.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| win32-link.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2021-03-19 23:56:45 | Re: BUG #16927: Postgres can`t access WAL files |
| Previous Message | Tom Lane | 2021-03-19 20:06:57 | Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when extracting epoch |