From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Add support for PROVE_FLAGS and PROVE_TESTS in MSVC scripts |
Date: | 2021-03-04 02:11:41 |
Message-ID: | YEBB3ROI/v9oAWQL@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Mar 03, 2021 at 08:59:30PM +0100, Juan José Santamaría Flecha wrote:
> This seems to me as if setting the variables in the shell is the proposed
> way to do so. In the previous doc point we do the same with the buildenv.pl
> file. It looks inconsistent, as if it was one way or the other, when it
> could be either.
Okay, that makes sense. PROVE_TESTS is a runtime-only dependency so
my guess is that most people would set that directly on the command
prompt like I do, still it can be useful to enforce that in build.pl.
PROVE_FLAGS can be both, but you are right that setting it in build.pl
would be the most common approach. So let's document both. Attached
is a proposal for that, what do you think? I have extended the
example of PROVE_FLAGS to show how to set up more --jobs.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
win32-tap-flags-v2.patch | text/x-diff | 1.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-03-04 02:18:42 | Re: PITR promote bug: Checkpointer writes to older timeline |
Previous Message | 'Alvaro Herrera' | 2021-03-04 01:51:08 | Re: PATCH: Batch/pipelining support for libpq |