| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: doc review for v14 |
| Date: | 2021-03-01 06:17:40 |
| Message-ID: | YDyHBBYSme6WvmYh@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 28, 2021 at 10:33:55PM -0600, Justin Pryzby wrote:
> I still have an issue with the sentence that begins:
> "Checksums are normally enabled..."
You could say here "Checksums can be enabled", but "normally" does not
sound bad to me either as it insists on the fact that it is better to
do that when the cluster is initdb'd as this has no downtime compared
to enabling checksums on an existing cluster.
> Note, the patch I sent said "create" but should be "created".
Initialized sounds better to me, FWIW.
> "page corruptions" is wrong .. you could say "corrupt pages"
"corruptED pages" would sound more correct to me as something that has
already happened. Anyway, I'd rather keep what I am proposing
upthread.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-03-01 06:30:44 | Re: [PATCH] refactor ATExec{En,Dis}ableRowSecurity |
| Previous Message | Corey Huinker | 2021-03-01 06:13:47 | Re: simplifying foreign key/RI checks |