Re: [PATCH] pgbench: Bug fix for the -d option

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: miyake_kouta <miyake_kouta(at)oss(dot)nttdata(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] pgbench: Bug fix for the -d option
Date: 2021-02-26 08:16:17
Message-ID: YDiuUYL48nRljvNQ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Feb 26, 2021 at 01:18:20PM +0900, miyake_kouta wrote:
> I'm suggesting this bug fix because I think it's a bug, but if there's any
> other intent to this else if statement, could you let me know?

Yes, the existing code could mess up with the selection logic if
PGPORT and PGUSER are both specified in an environment, masking the
value of PGUSER, so let's fix that. This is as old as 412893b.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2021-02-26 08:30:32 Re: libpq debug log
Previous Message Masahiko Sawada 2021-02-26 08:03:37 Re: 64-bit XIDs in deleted nbtree pages