Re: doc review for v14

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: doc review for v14
Date: 2021-02-25 08:05:27
Message-ID: YDdaR29pDIXpGTBQ@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 24, 2021 at 01:39:55AM -0600, Justin Pryzby wrote:
> On Wed, Feb 24, 2021 at 04:18:51PM +0900, Michael Paquier wrote:
>> + The status of each kind of extended statistics is shown in a column
>> + named after the "kind" (e.g. Ndistinct).
>> + NULL means that it doesn't exist. "defined" means that it was requested
>> From 0009, there is a grammar mistake on HEAD here, but I don't
>> understand what you mean by "kind" here. Wouldn't it be better to not
>> use quotes and just refer to "its type of statistics"?
>
> I mean stxkind. "type" doesn't mean anything.

How would you reword that then?

> - vacuum the main relation. This option is required when the
> + vacuum the main relation. This option may not be disabled when the
> <literal>FULL</literal> option is used.
>
> "This option is required.." sounds like "this option must be specified", which
> is wrong.

Hmm. Wouldn't it be better to say then "this option cannot be
disabled when FULL is used"?

> When creating an index on a partitioned table, this column is set to
> - the number of partitions on which the index has been completed.
> + the number of partitions on which the index has been created.
>
> What is index "completion" ?

Done with. Perhaps Alvaro has a comment to offer here as this comes
from ab0dfc9.

> This is very
> - convenient, as not only will the existing partitions become indexed, but
> - also any partitions that are created in the future will. One limitation is
> + convenient, as not only the existing partitions will be indexed, but
> + so will any partitions that are created in the future. One limitation is
>
> "become indexed" sounds strange (and vague), and "will." is additionally awkward.

Not that strange to me (see dbca945).
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-02-25 08:14:35 Re: Improvements and additions to COPY progress reporting
Previous Message Dilip Kumar 2021-02-25 07:52:53 Re: Is Recovery actually paused?