Re: Buildfarm failure in crake

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Buildfarm failure in crake
Date: 2021-03-03 06:03:28
Message-ID: YD8mDHdD8Exenndz@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 03, 2021 at 08:46:41AM +0530, vignesh C wrote:
> I noticed there is buildfarm failure in crake, it fails with the
> following error:
> Mar 02 21:22:56 ./src/test/recovery/t/001_stream_rep.pl: Variable
> declared in conditional statement at line 88, column 2. Declare
> variables outside of the condition.
> ([Variables::ProhibitConditionalDeclarations] Severity: 5)
>
> I felt the variable declaration and the assignment need to be split as
> it involves conditional statements. I have attached a patch which will
> help in fixing the problem.
> Thoughts?

Tom has fixed that with d422a2a.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-03-03 06:30:17 Re: cryptohash: missing locking functions for OpenSSL <= 1.0.2?
Previous Message Julien Rouhaud 2021-03-03 05:56:59 Re: REINDEX backend filtering