| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add SQL function for SHA1 |
| Date: | 2021-01-27 01:53:00 |
| Message-ID: | YBDHfHufJaO+xcy2@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 26, 2021 at 10:38:43AM +0100, Daniel Gustafsson wrote:
> Agreed, and pgcrypto already allows for using sha1.
>
> It seems like any legitimate need for sha1 could be better served by an
> extension rather than supplying it in-core.
Both of you telling the same thing is enough for me to discard this
new stuff. I'd like to refactor the code anyway as that's a nice
cleanup, and this would have the advantage to make people look at
cryptohashfuncs.c if introducing a new type. After sleeping about it,
I think that I would just make MD5 and SHA1 issue an elog(ERROR) if
the internal routine is taken in those cases, like in the attached.
If there are any comments or objections to the refactoring piece,
please let me know.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| cryptohashfunc-refactor.patch | text/x-diff | 5.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhihong Yu | 2021-01-27 02:19:44 | Re: logical replication worker accesses catalogs in error context callback |
| Previous Message | Michael Paquier | 2021-01-27 01:40:39 | Re: wiki:PostgreSQL_14_Open_Items |