From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Odd, intermittent failure in contrib/pageinspect |
Date: | 2021-01-20 06:29:09 |
Message-ID: | YAfNtb5VWkAb0sDK@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Jan 19, 2021 at 05:03:49PM -0500, Tom Lane wrote:
> It looks to me like heap_surgery ought to be okay, because it's operating
> on a temp table; if there are any page access conflicts on that, we've
> got BIG trouble ;-)
Bah, of course. I managed to miss this part.
> Poking around, I found a few other places where it looked like a skipped
> page could produce diffs in the expected output:
> contrib/amcheck/t/001_verify_heapam.pl
> contrib/pg_visibility/sql/pg_visibility.sql
>
> There are lots of other vacuums of course, but they don't look like
> a missed page would have any effect on the visible results, so I think
> we should leave them alone.
Yeah, I got to wonder a bit about check_btree.sql on a second look,
but that's no big deal to leave it alone either.
> In short I propose the attached patch, which also gets rid of
> that duplicate query.
Agreed, +1.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-01-20 06:30:07 | Re: [PATCH 1/1] Initial mach based shared memory support. |
Previous Message | Peter Eisentraut | 2021-01-20 06:25:37 | Re: Printing LSN made easy |