Re: Error messages on duplicate schema names

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Andrus <kobruleht2(at)hot(dot)ee>, pgsql-general(at)postgresql(dot)org
Subject: Re: Error messages on duplicate schema names
Date: 2021-01-20 02:56:03
Message-ID: YAebw/WH0t6YCd8S@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Tue, Jan 19, 2021 at 05:37:51PM -0300, Alvaro Herrera wrote:
> I guess you could make the case that the CCI call should be in the
> callers where we actually loop (SetDefaultACLsInSchemas,
> RemoveRoleFromObjectACL), but it's hard to get excited about the added
> clutter.

Yeah, that matches my thoughts. And I did not see any harm in putting
the CCI in SetDefaultACL() even for the case of pg_default_acl with
DROP OWNED BY. So applied and backpatched. Thanks, Alvaro and
Andrus.
--
Michael

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Atul Kumar 2021-01-20 09:53:56 upgrade using logical replication
Previous Message Tom Lane 2021-01-19 22:15:47 Re: Accounting for between table correlation