| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Adjust interaction of CREATEROLE with role properties. |
| Date: | 2023-01-27 03:06:02 |
| Message-ID: | Y9M/mqKqGXYt3jkC@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Jan 26, 2023 at 09:08:23PM -0500, Tom Lane wrote:
> Yeah ... if we put it into an existing script, somebody will blindly
> add more tests after it someday. I suggest calling it "test_cleanup"
> to pair with "test_setup".
>
> Is it worth checking for leftover regress_xxx tablespaces as well as
> roles?
Guess so. If this is to be applied to everything that fails under the
naming restrictions, there could be a point in doing the same for
databases, subscriptions and replication origins. Now the argument
has less weight for these object types, surely, compared to roles and
tbspaces.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2023-01-27 03:09:14 | pgsql: Teach planner about more monotonic window functions |
| Previous Message | Tom Lane | 2023-01-27 02:08:23 | Re: pgsql: Adjust interaction of CREATEROLE with role properties. |