Re: constify arguments of copy_file() and copydir()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: constify arguments of copy_file() and copydir()
Date: 2023-01-16 01:53:40
Message-ID: Y8SuJF7dp7ZsWYvc@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 15, 2023 at 08:13:28AM -0800, Nathan Bossart wrote:
> On Sun, Jan 15, 2023 at 08:23:13AM -0500, Andrew Dunstan wrote:
>> On 2023-01-14 Sa 18:11, Nathan Bossart wrote:
>>> I've attached a patch for $SUBJECT, which allows us to remove a use of the
>>> unconstify macro in basic_archive. This is just a pet peeve, but maybe it
>>> bothers others, too.
>>
>> I don't like using unconstify where it can be avoided, so this looks
>> reasonable to me.

+1.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2023-01-16 01:56:25 Re: Add LZ4 compression in pg_dump
Previous Message Kyotaro Horiguchi 2023-01-16 01:52:43 Re: Lazy allocation of pages required for verifying FPI consistency