| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, orlovmg(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |
| Date: | 2022-12-21 00:09:03 |
| Message-ID: | Y6JOnwuUIR4wNxaj@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 20, 2022 at 06:04:40PM +0530, Bharath Rupireddy wrote:
> On Tue, Dec 20, 2022 at 1:27 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> Caught this thread late. To me, pg_dissect_walfile_name() is a
>> really strange name for a function. Grepping our I code I see the
>> term dissect s used somewhere inside the regex code and exactly
>> zero instances elsewhere. Which is why I definitely didn't
>> recognize the term...
>>
>> Wouldn't something like pg_split_walfile_name() be a lot more
>> consistent with the rest of our names?
Fine by me to change that if there is little support for the current
naming, though the current one does not sound that bad to me either.
> Hm. FWIW, here's the patch.
"split" is used a lot for the picksplit functions, but not in any of
the existing functions as a name. Some extra options: parse, read,
extract, calculate, deduce, get. "parse" would be something I would
be OK with.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2022-12-21 00:14:48 | Avoid lost result of recursion (src/backend/optimizer/util/inherit.c) |
| Previous Message | Ian Lawrence Barwick | 2022-12-21 00:06:15 | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |