Incorrect include file order in guc-file.l

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Incorrect include file order in guc-file.l
Date: 2022-11-02 05:29:50
Message-ID: Y2IATvRGo347Lvd1@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

While reviewing a different patch, I have noticed that guc-file.l
includes sys/stat.h in the middle of the PG internal headers. The
usual practice is to have first postgres[_fe].h, followed by the
system headers and finally the internal headers. That's a nit, but
all the other files do that.

{be,fe}-secure-openssl.c include some exceptions though, as documented
there.

Thoughts?
--
Michael

Attachment Content-Type Size
gucfile-include.patch text/x-diff 490 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2022-11-02 05:34:54 Re: A new strategy for pull-up correlated ANY_SUBLINK
Previous Message Corey Huinker 2022-11-02 05:18:54 Re: psql: Add command to use extended query protocol