| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Some regression tests for the pg_control_*() functions |
| Date: | 2022-10-25 05:37:25 |
| Message-ID: | Y1d2FZmQmyAhPSRG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
As mentioned in [1], there is no regression tests for the SQL control
functions: pg_control_checkpoint, pg_control_recovery,
pg_control_system and pg_control_init.
It would be minimal to check their execution, as of a "SELECT FROM
func()", still some validation can be done on its output as long as
the test is portable enough (needs transparency for wal_level, commit
timestamps, etc.).
Attached is a proposal to provide some coverage. Some of the checks
could be just removed, like the ones for non-NULL fields, but I have
written out everything to show how much could be done.
Thoughts?
[1]: https://www.postgresql.org/message-id/YzY0iLxNbmaxHpbs@paquier.xyz
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| controldata-regression-3.patch | text/x-diff | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2022-10-25 05:40:23 | Re: fixing typo in comment for restriction_is_or_clause |
| Previous Message | Michael Paquier | 2022-10-25 05:20:12 | Re: Getting rid of SQLValueFunction |