| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: psql memory leaks |
| Date: | 2023-02-22 05:32:50 |
| Message-ID: | Y/WpAsFHDYFg1Yiy@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 21, 2023 at 02:03:43PM -0500, Corey Huinker wrote:
> Good catch. Patch passes make check-world.
Indeed. I was reviewing the whole and there could be a point in
resetting bind_nparams at the end of SendQuery() to keep a correct
track of what's saved in the pset data for the bind parameters, but
not doing so is not a big deal either because we'd just reset it once
the full allocation of the parameters is done and bind_flag is all
about that. The code paths leading to the free seem correct, seen
from here.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2023-02-22 06:15:30 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Hayato Kuroda (Fujitsu) | 2023-02-22 04:48:20 | RE: Time delayed LR (WAS Re: logical replication restrictions) |