Re: Doc update for pg_stat_statements normalization

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Imseih (AWS), Sami" <simseih(at)amazon(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc update for pg_stat_statements normalization
Date: 2023-03-01 00:09:57
Message-ID: Y/6X1WdVN+EOi23L@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Feb 28, 2023 at 11:11:30PM +0000, Imseih (AWS), Sami wrote:
> I agree. We introduce the concept of a plannable statement in a
> previous section and we can then make this distinction in the new
> paragraph.
>
> I also added a link to pg_stat_statements_info since that is introduced
> later on int the doc.

I have reworded the paragraph a bit to be more general so as it would
not need an update once more normalization is applied to utility
queries (I am going to fix the part where we mention that we use the
strings for utilities, which is not the case anymore now):
+ <para>
+ Queries on which normalization can be applied may be observed with constant
+ values in <structname>pg_stat_statements</structname>, especially when there
+ is a high rate of entry deallocations. To reduce the likelihood of this
+ happening, consider increasing <varname>pg_stat_statements.max</varname>.
+ The <structname>pg_stat_statements_info</structname> view, discussed below
+ in <xref linkend="pgstatstatements-pg-stat-statements-info"/>,
+ provides statistics about entry deallocations.
+ </para>

Are you OK with this text?
--
Michael

Attachment Content-Type Size
v3-0001-doc-update-regarding-pg_stat_statements-normaliza.patch text/x-diff 1.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2023-03-01 00:43:10 Re: pg_upgrade and logical replication
Previous Message Justin Pryzby 2023-02-28 23:58:34 Re: Add LZ4 compression in pg_dump