| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Katsuragi Yuta <katsuragiy(at)oss(dot)nttdata(dot)com> |
| Cc: | pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: meson doc: Is "-Dtap-tests" a typo? |
| Date: | 2023-02-15 04:44:07 |
| Message-ID: | Y+xjFxRHr9WDFQrw@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Tue, Feb 14, 2023 at 09:06:13AM +0000, Katsuragi Yuta wrote:
> The parameter name "-Dtap-tests" in the meson's doc seems to be a typo.
> I think "-Dtap_tests" is the correct name. Attached patch fixes that.
>
> I got an unknown options error by using "-Dtap-tests=enabled". However,
> meson_options.txt told me the correct name was "-Dtap_tests".
<varlistentry id="configure-tap-tests-meson">
- <term><option>-Dtap-tests={ auto | enabled | disabled }</option></term>
+ <term><option>-Dtap_tests={ auto | enabled | disabled }</option></term>
And meson.build refers to the same term, as of "tap_tests":
# Check whether tap tests are enabled or not
tap_tests_enabled = false
tapopt = get_option('tap_tests')
So you are indeed right. Nice catch. Will fix.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Katsuragi Yuta | 2023-02-15 06:28:26 | Re: meson doc: Is "-Dtap-tests" a typo? |
| Previous Message | Katsuragi Yuta | 2023-02-14 09:06:13 | meson doc: Is "-Dtap-tests" a typo? |