Re: Some more hackery around cryptohashes (some fixes + SHA1)

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Some more hackery around cryptohashes (some fixes + SHA1)
Date: 2020-12-14 03:48:15
Message-ID: X9bgf+Cge68alckx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Dec 10, 2020 at 05:07:05PM +0900, Michael Paquier wrote:
> - 0001 is a set of small adjustments for the existing code of
> cryptohashes: some cleanup for MD5 in uuid-ossp, and more importantly
> one fix to call explicit_bzero() on the context data for the fallback
> implementations. With the existing code, we may leave behind some
> context data. That could become a problem if somebody has access to
> this area of the memory even when they should not be able to do so,
> something that should not happen, but I see no reason to not play it
> safe and eliminate any traces. If there are no objections, I'd like
> to apply this part.

This is a nice cleanup, so I have moved ahead and applied it. A
rebased version of the SHA1 business is attached.
--
Michael

Attachment Content-Type Size
v2-0001-Introduce-SHA1-in-cryptohash-infrastructure.patch text/x-diff 33.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-12-14 03:52:35 Re: please update ps display for recovery checkpoint
Previous Message Justin Pryzby 2020-12-14 03:22:24 Re: please update ps display for recovery checkpoint