Re: pgsql: Move SHA2 routines to a new generic API layer for crypto hashes

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Move SHA2 routines to a new generic API layer for crypto hashes
Date: 2020-12-02 03:21:16
Message-ID: X8cILLWdpeSAgDr4@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, Dec 02, 2020 at 12:14:33PM +0900, Michael Paquier wrote:
> Neither gcc nor clang complain on my end, even with
> -Werror=maybe-uninitialized, because they understand that the status
> will be set anyway as we have no default in the switch? :)
>
> You are right, this is bad practice for those code paths, so let's fix
> it. Which version are you using? I'd like to be able to reproduce
> that and double-check if there are more missing spots.

Hmm. Forget that. I can see the warnings once I switched to -O2,
which is what I guess you are doing. Some animals are also showing
that. I'll fix in a minute. Thanks for the report!
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-12-02 03:31:30 pgsql: Fix compilation warnings in cryptohash_openssl.c
Previous Message Michael Paquier 2020-12-02 03:14:33 Re: pgsql: Move SHA2 routines to a new generic API layer for crypto hashes