From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomasz Szypowski <tomasz(dot)szypowski(at)gmail(dot)com> |
Subject: | Re: pg_upgrade version checking questions |
Date: | 2019-03-19 13:00:50 |
Message-ID: | X1HXn_mQss5BNMw0chrINg4kbhZ7_49H541REZK7HF3QvM366Tl_KkEs2K_9T6_sWeYBOhG3XolUHmdCo6kyu-4LXCz-DHhfJL_XMNd6KTk=@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tuesday, March 19, 2019 7:55 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Tue, Mar 19, 2019 at 02:43:49AM -0400, Bruce Momjian wrote:
>
> > > 3. Actually, I'm kind of wondering why pg_upgrade has a --new-bindir
> > > option at all, rather than just insisting on finding the new-version
> > > executables in the same directory it is in. This seems like, at best,
> > > a hangover from before it got into core. Even if you don't want to
> > > remove the option, we could surely provide a useful default setting
> > > based on find_my_exec. (I'm amused to notice that pg_upgrade
> > > currently takes the trouble to find out its own path, and then does
> > > precisely nothing with the information.)
> > >
> >
> > Good point. You are right that when it was outside of the source tree,
> > and even in /contrib, that would not have worked easily. Makes sense to
> > at least default to the same directory as pg_upgrade.
>
> I guess an open question is whether we should remove the --new-bindir
> option completely.
If the default is made to find the new-version binaries in the same directory,
keeping --new-bindir could still be useful for easier testing of pg_upgrade.
cheers ./daniel
From | Date | Subject | |
---|---|---|---|
Next Message | Dmitry Dolgov | 2019-03-19 13:07:32 | Re: Index Skip Scan |
Previous Message | Fabien COELHO | 2019-03-19 12:45:40 | Re: Offline enabling/disabling of data checksums |