| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com> |
| Subject: | Re: Track replica origin progress for Rollback Prepared |
| Date: | 2021-01-06 11:48:22 |
| Message-ID: | X/Wjhg4bWMlR3BbG@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 05, 2021 at 04:24:21PM +0530, Amit Kapila wrote:
> There are already tests [1] in one of the upcoming patches for logical
> decoding of 2PC which covers this code using which I have found this
> problem. So, I thought those would be sufficient. I have not checked
> the feasibility of using test_decoding because I thought adding more
> using test_decoding will unnecessarily duplicate the tests.
Hmm. This stuff does not check after replication origins even if it
stresses 2PC, so that looks incomplete when seen from here.
> How about something like "Dump transaction origin information only for
> abort prepared. We need this during recovery to update the replication
> origin progress."?
That sounds fine.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-01-06 12:58:51 | Re: Track replica origin progress for Rollback Prepared |
| Previous Message | Michael Paquier | 2021-01-06 11:42:53 | Re: Incorrect allocation handling for cryptohash functions with OpenSSL |